fix: code review fixes - remove dead verdict variable, fix safety valve, fix fragile test, use tool factories

Co-authored-by: Kenearos <86194771+Kenearos@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-03-12 22:27:14 +00:00
parent d4cfb34423
commit 071f994e20
4 changed files with 49 additions and 27 deletions

View file

@ -22,8 +22,8 @@ from langchain_openai import ChatOpenAI
from langgraph.graph import END, StateGraph
from state import CouncilState, APPROVAL_THRESHOLD, MAX_ITERATIONS
from tools.web_search import web_search
from tools.pdf_reader import pdf_search
from tools.web_search import create_web_search_tool
from tools.pdf_reader import create_pdf_search_tool
# ---------------------------------------------------------------------------
@ -76,9 +76,13 @@ def _resolve_tools(tools_config: Optional[dict]) -> list:
resolved = []
if tools_config.get("webSearch"):
resolved.append(web_search)
tool = create_web_search_tool()
if tool is not None:
resolved.append(tool)
if tools_config.get("pdfReader"):
resolved.append(pdf_search)
tool = create_pdf_search_tool()
if tool is not None:
resolved.append(tool)
return resolved