its-consulting/KI-Konzil
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: code review fixes - remove dead verdict variable, fix safety valve, fix fragile test, use tool factories

Browse source 
Co-authored-by: Kenearos <86194771+Kenearos@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-03-12 22:27:14 +00:00
parent d4cfb34423
commit 071f994e20
4 changed files with 49 additions and 27 deletions
Download patch file Download diff file Expand all files Collapse all files

23
backend/tests/test_god_mode.py
View file

@ -110,8 +110,12 @@ class TestToolResolution:
def test_resolve_tools_web_search_only(self):
from services.dynamic_graph_builder import _resolve_tools
import os
tools = _resolve_tools({"webSearch": True, "pdfReader": False})
with __import__("unittest.mock", fromlist=["patch"]).patch.dict(
os.environ, {"TAVILY_API_KEY": "test-key"}
):
tools = _resolve_tools({"webSearch": True, "pdfReader": False})
assert len(tools) == 1
assert tools[0].name == "web_search"
@ -124,12 +128,27 @@ class TestToolResolution:
def test_resolve_tools_both(self):
from services.dynamic_graph_builder import _resolve_tools
import os
tools = _resolve_tools({"webSearch": True, "pdfReader": True})
with __import__("unittest.mock", fromlist=["patch"]).patch.dict(
os.environ, {"TAVILY_API_KEY": "test-key"}
):
tools = _resolve_tools({"webSearch": True, "pdfReader": True})
assert len(tools) == 2
names = {t.name for t in tools}
assert names == {"web_search", "pdf_search"}
def test_resolve_tools_web_search_skipped_when_no_api_key(self):
from services.dynamic_graph_builder import _resolve_tools
import os
env = {k: v for k, v in os.environ.items() if k != "TAVILY_API_KEY"}
with __import__("unittest.mock", fromlist=["patch"]).patch.dict(
os.environ, env, clear=True
):
tools = _resolve_tools({"webSearch": True, "pdfReader": False})
assert tools == []
class TestInvokeWithTools:
"""Tests for the _invoke_with_tools helper."""