Fix React hook anti-patterns, incorrect mock paths, and unused code

- Replace useState+useEffect sync pattern with useMemo in
  EdgeSettingsPanel.tsx to eliminate cascading re-renders
- Remove redundant draft state in NodeSettingsPanel.tsx and use
  store data directly, eliminating useEffect sync loop
- Fix mock paths in test_tools.py: patch tavily.TavilyClient and
  pypdf.PdfReader at their source modules (lazy imports)
- Remove unused variable assignment in routes.py (god mode reject)
- Remove unused node_lookup dicts in dynamic_graph_builder.py
- Remove unused imports across test files (Blueprint, CouncilState,
  pytest, llm assignments)
- Remove unused CouncilBlueprint type import in types.test.ts
- Run npm audit fix to resolve moderate vulnerability

All 107 backend tests and 26 frontend tests pass. Ruff, ESLint,
and TypeScript checks are clean.

https://claude.ai/code/session_01XqzyT6fhS8sUe9P5fCmuVU
This commit is contained in:
Claude 2026-02-22 10:29:54 +00:00
parent fb0d3ae8f1
commit 7becffcc89
No known key found for this signature in database
11 changed files with 2332 additions and 65 deletions

View file

@ -1,7 +1,6 @@
import { describe, it, expect } from "vitest";
import type {
AgentNodeData,
CouncilBlueprint,
ExecutionMode,
GodModeAction,
GodModeState,

View file

@ -1,6 +1,6 @@
"use client";
import { useEffect, useState } from "react";
import { useMemo } from "react";
import { X, ArrowRight } from "lucide-react";
import { EdgeType } from "@/app/types/council";
import { useCouncilStore } from "@/app/store/council-store";
@ -15,15 +15,15 @@ export function EdgeSettingsPanel() {
const edge = edges.find((e) => e.id === selectedEdgeId);
const [edgeType, setEdgeType] = useState<EdgeType>("linear");
const [condition, setCondition] = useState("");
useEffect(() => {
if (edge) {
setEdgeType((edge.data?.type as EdgeType) ?? "linear");
setCondition((edge.data?.condition as string) ?? "");
}
}, [selectedEdgeId, edge]);
// Derive state directly from the store instead of syncing via useEffect
const edgeType = useMemo(
() => (edge?.data?.type as EdgeType) ?? "linear",
[edge?.data?.type]
);
const condition = useMemo(
() => (edge?.data?.condition as string) ?? "",
[edge?.data?.condition]
);
if (!selectedEdgeId || !edge) return null;
@ -31,12 +31,10 @@ export function EdgeSettingsPanel() {
const targetNode = nodes.find((n) => n.id === edge.target);
const handleTypeChange = (newType: EdgeType) => {
setEdgeType(newType);
updateEdgeData(selectedEdgeId, newType, newType === "conditional" ? condition : undefined);
};
const handleConditionChange = (value: string) => {
setCondition(value);
updateEdgeData(selectedEdgeId, edgeType, value);
};

View file

@ -1,6 +1,5 @@
"use client";
import { useEffect, useState } from "react";
import { X, Bot } from "lucide-react";
import { AgentNodeData, LLMModel } from "@/app/types/council";
import { useCouncilStore } from "@/app/store/council-store";
@ -21,18 +20,9 @@ export function NodeSettingsPanel() {
const node = nodes.find((n) => n.id === selectedNodeId);
const data = node?.data as AgentNodeData | undefined;
// Local draft to avoid re-renders on every keystroke
const [draft, setDraft] = useState<AgentNodeData | null>(null);
useEffect(() => {
setDraft(data ?? null);
}, [selectedNodeId, data]);
if (!selectedNodeId || !draft) return null;
if (!selectedNodeId || !data) return null;
const commit = (partial: Partial<AgentNodeData>) => {
const updated = { ...draft, ...partial };
setDraft(updated);
updateNodeData(selectedNodeId, partial);
};
@ -57,7 +47,7 @@ export function NodeSettingsPanel() {
<label className="text-xs font-medium text-slate-500">Name</label>
<input
type="text"
value={draft.label}
value={data.label}
onChange={(e) => commit({ label: e.target.value })}
className="rounded-lg border border-slate-200 px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-indigo-300"
/>
@ -69,7 +59,7 @@ export function NodeSettingsPanel() {
System-Prompt
</label>
<textarea
value={draft.systemPrompt}
value={data.systemPrompt}
onChange={(e) => commit({ systemPrompt: e.target.value })}
rows={6}
placeholder="Beschreibe die Rolle und das Verhalten dieses Agenten..."
@ -81,7 +71,7 @@ export function NodeSettingsPanel() {
<div className="flex flex-col gap-1">
<label className="text-xs font-medium text-slate-500">Modell</label>
<select
value={draft.model}
value={data.model}
onChange={(e) => commit({ model: e.target.value as LLMModel })}
className="rounded-lg border border-slate-200 px-3 py-2 text-sm focus:outline-none focus:ring-2 focus:ring-indigo-300"
>
@ -100,9 +90,9 @@ export function NodeSettingsPanel() {
<label className="flex items-center gap-3 cursor-pointer">
<input
type="checkbox"
checked={draft.tools.webSearch}
checked={data.tools.webSearch}
onChange={(e) =>
commit({ tools: { ...draft.tools, webSearch: e.target.checked } })
commit({ tools: { ...data.tools, webSearch: e.target.checked } })
}
className="h-4 w-4 rounded border-slate-300 text-indigo-600 focus:ring-indigo-300"
/>
@ -112,9 +102,9 @@ export function NodeSettingsPanel() {
<label className="flex items-center gap-3 cursor-pointer">
<input
type="checkbox"
checked={draft.tools.pdfReader}
checked={data.tools.pdfReader}
onChange={(e) =>
commit({ tools: { ...draft.tools, pdfReader: e.target.checked } })
commit({ tools: { ...data.tools, pdfReader: e.target.checked } })
}
className="h-4 w-4 rounded border-slate-300 text-indigo-600 focus:ring-indigo-300"
/>

File diff suppressed because it is too large Load diff