its-consulting/ralph-claude-code
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: address PR review feedback from CodeRabbit

Browse source 
- Disable live mode when build_claude_command fails (not just empty array)
- Strengthen safety check to verify use_modern_cli=true
- Fix case-sensitive sed range in test (execute→Execute)
- Update CLAUDE.md: auto-switch docs, test counts (484→490)
This commit is contained in:
Test User 2026-02-07 16:54:41 -07:00
parent 4027ac929a
commit 131b95db38
3 changed files with 15 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
tests/unit/test_cli_modern.bats
View file

@ -740,10 +740,11 @@ EOF
@test "safety check prevents live mode with empty CLAUDE_CMD_ARGS" {
# Verify ralph_loop.sh has the safety check for empty CLAUDE_CMD_ARGS
run grep -A3 'CLAUDE_CMD_ARGS.*-eq 0' "${BATS_TEST_DIRNAME}/../../ralph_loop.sh"
# The check also verifies use_modern_cli is true (not just non-empty array)
run grep -A3 'use_modern_cli.*CLAUDE_CMD_ARGS.*-eq 0' "${BATS_TEST_DIRNAME}/../../ralph_loop.sh"
# Should find safety check that falls back to background mode
[[ "$output" == *"LIVE_OUTPUT"* ]] || [[ "$output" == *"empty"* ]] || [[ "$output" == *"background"* ]]
[[ "$output" == *"LIVE_OUTPUT"* ]] || [[ "$output" == *"background"* ]]
}
@test "build_claude_command is called regardless of output format in ralph_loop.sh" {
@ -757,7 +758,7 @@ EOF
# The old pattern: "json" check immediately followed by build_claude_command
# should no longer exist as a gate
run bash -c "sed -n '/# Build the Claude CLI command/,/execute Claude Code/p' '$script' | grep -c 'CLAUDE_OUTPUT_FORMAT.*json.*build_claude_command'"
run bash -c "sed -n '/# Build the Claude CLI command/,/# Execute Claude Code/p' '$script' | grep -c 'CLAUDE_OUTPUT_FORMAT.*json.*build_claude_command'"
# Should find 0 matches (the gate has been removed)
[[ "$output" == "0" ]]