its-consulting/ralph-claude-code
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix critical bug: incorrect return code check in exit logic

Browse source 
The issue was in line 378: if [[ $? -eq 0 ]]
- $? was checking the return code of 'local exit_reason=$(...)'
- This command always succeeds, so $? was always 0
- This caused Ralph to always exit immediately after loop #1

Fixed by:
- Calling should_exit_gracefully directly in the if condition
- Only calling it again to get exit reason if it returns 0 (exit needed)
- This properly checks the function's actual return code
This commit is contained in:
frankbria 2025-08-27 16:12:09 -07:00
parent a09957c068
commit 2a5452c18f
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
ralph_loop.sh
View file

@ -374,8 +374,8 @@ main() {
fi fi
# Check for graceful exit conditions # Check for graceful exit conditions
local exit_reason=$(should_exit_gracefully) if should_exit_gracefully; then
if [[ $? -eq 0 ]]; then local exit_reason=$(should_exit_gracefully)
log_status "SUCCESS" "🏁 Graceful exit triggered: $exit_reason" log_status "SUCCESS" "🏁 Graceful exit triggered: $exit_reason"
update_status "$loop_count" "$(cat "$CALL_COUNT_FILE")" "graceful_exit" "completed" "$exit_reason" update_status "$loop_count" "$(cat "$CALL_COUNT_FILE")" "graceful_exit" "completed" "$exit_reason"