Commit graph

2 commits

Author SHA1 Message Date
frankbria
7407f0f45b test(cli): add --allowed-tools test and code review report
Address code review finding by adding dedicated test for
--allowed-tools flag validation.

Add code review report documenting:
- 0 critical issues
- 0 major issues
- 1 minor issue (addressed in this commit)
- 6 positive findings

Test count: 27 CLI parsing tests (105 total unit tests)

Refs #10
2026-01-08 22:42:50 -07:00
frankbria
fffcc26427 test(cli): add comprehensive CLI argument parsing tests
Add 26 new BATS tests validating all CLI flags in ralph_loop.sh:

- Help flag tests (2): --help, -h short flag
- Flag value tests (6): --calls, --prompt, --monitor, --verbose, --timeout
- Status flag tests (2): --status with/without status.json
- Circuit breaker tests (2): --reset-circuit, --circuit-status
- Invalid input tests (3): unknown flag, invalid timeout, invalid format
- Multiple flags tests (3): combinations, all flags, early exit
- Flag order tests (2): verify order independence
- Short flag tests (6): -c, -p, -s, -m, -v, -t equivalence

Test strategy uses --help as early-exit escape to validate parsing
without triggering main loop execution.

Closes #10
2026-01-08 22:38:23 -07:00