ralph-claude-code/tests/integration/test_project_setup.bats
Frank Bria 9b19d70e35
feat(structure): migrate Ralph files to .ralph/ subfolder (#109)
* feat(structure): migrate Ralph files to .ralph/ subfolder

BREAKING CHANGE: Ralph configuration files now live in .ralph/ subfolder

This refactoring moves all Ralph-specific files into a hidden .ralph/
directory while keeping src/ at the project root. This improves
compatibility with existing tooling and keeps the project root clean.

Changes:
- Move PROMPT.md, @fix_plan.md, @AGENT.md to .ralph/
- Move specs/, logs/, docs/generated/, examples/ to .ralph/
- Move state files (.response_analysis, .circuit_breaker_state, etc.) to .ralph/
- Keep src/ at project root (unchanged)
- Add RALPH_DIR=".ralph" configuration variable
- Add ralph-migrate command for existing projects
- Create migrate_to_ralph_folder.sh migration script
- Update all path references in scripts and tests
- Update documentation (README.md, CLAUDE.md)

New project structure:
  project/
  ├── .ralph/           # Ralph configuration
  │   ├── PROMPT.md
  │   ├── @fix_plan.md
  │   ├── @AGENT.md
  │   ├── specs/
  │   ├── logs/
  │   └── docs/generated/
  └── src/              # Source code (unchanged)

Migration: Run `ralph-migrate` in existing projects to upgrade.

All 310 tests pass (100% pass rate).

* chore: add .claude/settings.local.json to .gitignore

* fix: address code review feedback for .ralph/ subfolder structure

Fixes multiple path-related issues identified in code review:

Test fixes:
- Fix create_sample_prompt to use $RALPH_DIR/PROMPT.md in test_session_continuity.bats
- Fix result_file path to use $RALPH_DIR/.json_parse_result in test_json_parsing.bats
- Fix @fix_plan.md and .response_analysis paths in test_cli_modern.bats
- Update templates directory missing test to account for global fallback

Template fix:
- Fix @fix_plan.md reference in templates/PROMPT.md to use .ralph/ prefix

Script fixes:
- Fix PROMPT_FILE comparison in ralph_loop.sh to use $RALPH_DIR/PROMPT.md
- Fix examples migration logic in migrate_to_ralph_folder.sh (remove premature mkdir)
- Move templates directory check AFTER cd in setup.sh (was checking wrong location)
- Add template directory validation with fallback to global templates

All 310 tests pass.

* Update migrate_to_ralph_folder.sh

Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>

* fix: address code review feedback for .ralph/ subfolder structure

Code Review Fixes:
- Fix test_json_parsing.bats: all result_file and session file paths now use $RALPH_DIR prefix
- Fix ralph_loop.sh help text: paths now show .ralph/.ralph_session, .ralph/.call_count, etc.
- Fix migrate_to_ralph_folder.sh:
  - Proper error handling for date command (separate local declaration)
  - Use cp -a source/. dest/ pattern to preserve dotfiles and attributes
  - Remove 2>/dev/null suppression to surface copy errors
- Update create_files.sh to use .ralph/ structure for embedded scripts
- Update .gitignore with all .ralph/ state file paths
- Add old structure detection in ralph_loop.sh with helpful migration message

Version Update:
- Bump to v0.10.0 (breaking change: structural reorganization)
- Update README.md and CLAUDE.md with new version and release notes
- Add ralph-migrate documentation to Key Commands section

All 310 tests pass.

---------

Co-authored-by: macroscopeapp[bot] <170038800+macroscopeapp[bot]@users.noreply.github.com>
2026-01-20 23:22:30 -07:00

491 lines
14 KiB
Bash

#!/usr/bin/env bats
# Integration tests for Ralph project setup (setup.sh)
# Tests directory creation, template copying, git initialization, and README creation
load '../helpers/test_helper'
load '../helpers/fixtures'
# Store the path to setup.sh from the project root
SETUP_SCRIPT=""
setup() {
# Create unique temporary test directory
TEST_DIR="$(mktemp -d)"
cd "$TEST_DIR"
# Store setup.sh path (relative to test directory)
SETUP_SCRIPT="${BATS_TEST_DIRNAME}/../../setup.sh"
# Set git author info via environment variables (avoids mutating global config)
export GIT_AUTHOR_NAME="Test User"
export GIT_AUTHOR_EMAIL="test@example.com"
export GIT_COMMITTER_NAME="Test User"
export GIT_COMMITTER_EMAIL="test@example.com"
# Create mock templates directory (simulating ../templates relative to project being created)
mkdir -p templates/specs
# Create mock template files with minimal but valid content
cat > templates/PROMPT.md << 'EOF'
# Ralph Development Instructions
## Context
You are Ralph, an autonomous AI development agent.
## Current Objectives
1. Follow @fix_plan.md for current priorities
2. Implement using best practices
3. Run tests after each implementation
EOF
cat > templates/fix_plan.md << 'EOF'
# Ralph Fix Plan
## High Priority
- [ ] Initial setup task
## Medium Priority
- [ ] Secondary task
## Notes
- Focus on MVP functionality first
EOF
cat > templates/AGENT.md << 'EOF'
# Agent Build Instructions
## Project Setup
```bash
npm install
```
## Running Tests
```bash
npm test
```
EOF
# Create a sample spec file
cat > templates/specs/sample_spec.md << 'EOF'
# Sample Specification
This is a sample spec file for testing.
EOF
}
teardown() {
# Clean up test directory
if [[ -n "$TEST_DIR" ]] && [[ -d "$TEST_DIR" ]]; then
cd /
rm -rf "$TEST_DIR"
fi
}
# =============================================================================
# Test: Project Directory Creation
# =============================================================================
@test "setup.sh creates project directory" {
run bash "$SETUP_SCRIPT" test-project
assert_success
assert_dir_exists "test-project"
}
@test "setup.sh handles project name with hyphens" {
run bash "$SETUP_SCRIPT" my-test-project
assert_success
assert_dir_exists "my-test-project"
}
@test "setup.sh handles project name with underscores" {
run bash "$SETUP_SCRIPT" my_test_project
assert_success
assert_dir_exists "my_test_project"
}
# =============================================================================
# Test: Subdirectory Structure (.ralph/ subfolder)
# =============================================================================
@test "setup.sh creates .ralph subdirectory for Ralph-specific files" {
run bash "$SETUP_SCRIPT" test-project
assert_success
assert_dir_exists "test-project/.ralph"
}
@test "setup.sh creates all required subdirectories in .ralph/" {
run bash "$SETUP_SCRIPT" test-project
assert_success
# Ralph-specific directories go inside .ralph/
assert_dir_exists "test-project/.ralph/specs"
assert_dir_exists "test-project/.ralph/specs/stdlib"
assert_dir_exists "test-project/.ralph/examples"
assert_dir_exists "test-project/.ralph/logs"
assert_dir_exists "test-project/.ralph/docs"
assert_dir_exists "test-project/.ralph/docs/generated"
# src/ stays at root per maintainer decision
assert_dir_exists "test-project/src"
}
@test "setup.sh keeps src directory at project root (not in .ralph/)" {
run bash "$SETUP_SCRIPT" test-project
assert_success
# src should be at root, NOT inside .ralph
assert_dir_exists "test-project/src"
[[ ! -d "test-project/.ralph/src" ]]
}
@test "setup.sh creates nested docs/generated directory in .ralph/" {
run bash "$SETUP_SCRIPT" test-project
assert_success
# Verify the nested structure exists inside .ralph
[[ -d "test-project/.ralph/docs/generated" ]]
}
@test "setup.sh creates nested specs/stdlib directory in .ralph/" {
run bash "$SETUP_SCRIPT" test-project
assert_success
[[ -d "test-project/.ralph/specs/stdlib" ]]
}
# =============================================================================
# Test: Template Copying (to .ralph/ subfolder)
# =============================================================================
@test "setup.sh copies PROMPT.md template to .ralph/" {
run bash "$SETUP_SCRIPT" test-project
assert_success
assert_file_exists "test-project/.ralph/PROMPT.md"
# Verify content matches source
diff templates/PROMPT.md test-project/.ralph/PROMPT.md
}
@test "setup.sh copies fix_plan.md as @fix_plan.md to .ralph/" {
run bash "$SETUP_SCRIPT" test-project
assert_success
assert_file_exists "test-project/.ralph/@fix_plan.md"
# Verify content matches source
diff templates/fix_plan.md "test-project/.ralph/@fix_plan.md"
}
@test "setup.sh copies AGENT.md as @AGENT.md to .ralph/" {
run bash "$SETUP_SCRIPT" test-project
assert_success
assert_file_exists "test-project/.ralph/@AGENT.md"
# Verify content matches source
diff templates/AGENT.md "test-project/.ralph/@AGENT.md"
}
@test "setup.sh copies specs templates to .ralph/specs/" {
run bash "$SETUP_SCRIPT" test-project
assert_success
# Verify spec file was copied to .ralph/specs/
assert_file_exists "test-project/.ralph/specs/sample_spec.md"
}
@test "setup.sh handles empty specs directory gracefully" {
# Remove spec files
rm -f templates/specs/*
run bash "$SETUP_SCRIPT" test-project
# Should not fail (|| true in script handles this)
assert_success
assert_dir_exists "test-project/.ralph/specs"
}
@test "setup.sh handles missing specs directory gracefully" {
# Remove specs directory entirely
rm -rf templates/specs
run bash "$SETUP_SCRIPT" test-project
# Should not fail due to || true in script
assert_success
assert_dir_exists "test-project/.ralph/specs"
}
# =============================================================================
# Test: Git Initialization
# =============================================================================
@test "setup.sh initializes git repository" {
run bash "$SETUP_SCRIPT" test-project
assert_success
assert_dir_exists "test-project/.git"
}
@test "setup.sh creates valid git repository" {
bash "$SETUP_SCRIPT" test-project
cd test-project
run command git rev-parse --git-dir
assert_success
assert_equal "$output" ".git"
}
@test "setup.sh creates initial git commit" {
bash "$SETUP_SCRIPT" test-project
cd test-project
run command git log --oneline
assert_success
# Should have at least one commit
[[ -n "$output" ]]
}
@test "setup.sh uses correct initial commit message" {
bash "$SETUP_SCRIPT" test-project
cd test-project
run command git log -1 --pretty=%B
assert_success
# Remove trailing whitespace for comparison
local commit_msg=$(echo "$output" | tr -d '\n')
assert_equal "$commit_msg" "Initial Ralph project setup"
}
@test "setup.sh commits all files in initial commit" {
bash "$SETUP_SCRIPT" test-project
cd test-project
run command git status --porcelain
assert_success
# Working tree should be clean (no uncommitted changes)
assert_equal "$output" ""
}
# =============================================================================
# Test: README Creation
# =============================================================================
@test "setup.sh creates README.md" {
run bash "$SETUP_SCRIPT" test-project
assert_success
assert_file_exists "test-project/README.md"
}
@test "setup.sh README contains project name" {
bash "$SETUP_SCRIPT" test-project
# Verify README contains the project name as heading
grep -q "# test-project" test-project/README.md
}
@test "setup.sh README is not empty" {
bash "$SETUP_SCRIPT" test-project
# File should have content
[[ -s "test-project/README.md" ]]
}
# =============================================================================
# Test: Custom Project Name
# =============================================================================
@test "setup.sh accepts custom project name as argument" {
run bash "$SETUP_SCRIPT" custom-project-name
assert_success
assert_dir_exists "custom-project-name"
}
@test "setup.sh custom project has correct README heading" {
bash "$SETUP_SCRIPT" custom-project-name
grep -q "# custom-project-name" custom-project-name/README.md
}
@test "setup.sh custom project has all subdirectories in .ralph/" {
bash "$SETUP_SCRIPT" my-custom-app
# Ralph-specific dirs in .ralph/
assert_dir_exists "my-custom-app/.ralph/specs/stdlib"
assert_dir_exists "my-custom-app/.ralph/examples"
assert_dir_exists "my-custom-app/.ralph/logs"
assert_dir_exists "my-custom-app/.ralph/docs/generated"
# src stays at root
assert_dir_exists "my-custom-app/src"
}
@test "setup.sh custom project has all template files in .ralph/" {
bash "$SETUP_SCRIPT" my-custom-app
assert_file_exists "my-custom-app/.ralph/PROMPT.md"
assert_file_exists "my-custom-app/.ralph/@fix_plan.md"
assert_file_exists "my-custom-app/.ralph/@AGENT.md"
}
# =============================================================================
# Test: Default Project Name
# =============================================================================
@test "setup.sh uses default project name when none provided" {
run bash "$SETUP_SCRIPT"
assert_success
# Default name is "my-project" per line 6 of setup.sh
assert_dir_exists "my-project"
}
@test "setup.sh default project has correct README heading" {
bash "$SETUP_SCRIPT"
grep -q "# my-project" my-project/README.md
}
@test "setup.sh default project has all required structure in .ralph/" {
bash "$SETUP_SCRIPT"
# Verify .ralph directory exists
assert_dir_exists "my-project/.ralph"
# Verify all directories in .ralph/
assert_dir_exists "my-project/.ralph/specs/stdlib"
assert_dir_exists "my-project/.ralph/examples"
assert_dir_exists "my-project/.ralph/logs"
assert_dir_exists "my-project/.ralph/docs/generated"
# src stays at root
assert_dir_exists "my-project/src"
# Verify all files in .ralph/
assert_file_exists "my-project/.ralph/PROMPT.md"
assert_file_exists "my-project/.ralph/@fix_plan.md"
assert_file_exists "my-project/.ralph/@AGENT.md"
# README stays at root
assert_file_exists "my-project/README.md"
}
# =============================================================================
# Test: Working Directory Behavior
# =============================================================================
@test "setup.sh works from nested directory" {
# Create a separate working area nested inside TEST_DIR
mkdir -p work-area/subdir1/subdir2
# setup.sh does: cd $PROJECT_NAME && cp ../templates/PROMPT.md .
# So templates needs to be in the SAME directory where we run setup.sh
# (i.e., a sibling of the project directory that gets created)
cp -r templates work-area/subdir1/subdir2/
cd work-area/subdir1/subdir2
run bash "$SETUP_SCRIPT" nested-project
assert_success
assert_dir_exists "nested-project"
}
@test "setup.sh creates project in current directory" {
# Project should be created relative to where script is run, not where script lives
mkdir -p work-area
cd work-area
# Copy templates so they're accessible
cp -r "$TEST_DIR/templates" .
run bash "$SETUP_SCRIPT" local-project
assert_success
# Project should be in work-area directory
assert_dir_exists "local-project"
}
# =============================================================================
# Test: Output Messages
# =============================================================================
@test "setup.sh outputs startup message with project name" {
run bash "$SETUP_SCRIPT" test-project
assert_success
[[ "$output" == *"Setting up Ralph project: test-project"* ]]
}
@test "setup.sh outputs completion message" {
run bash "$SETUP_SCRIPT" test-project
assert_success
[[ "$output" == *"Project test-project created"* ]]
}
@test "setup.sh outputs next steps guidance with .ralph paths" {
run bash "$SETUP_SCRIPT" test-project
assert_success
[[ "$output" == *"Next steps:"* ]]
[[ "$output" == *".ralph/PROMPT.md"* ]]
}
# =============================================================================
# Test: Error Handling
# =============================================================================
@test "setup.sh fails if templates directory missing" {
# Remove local templates directory
rm -rf templates
# Also hide global templates by overriding HOME to a temp location
local original_home="$HOME"
export HOME="$(mktemp -d)"
run bash "$SETUP_SCRIPT" test-project
# Restore HOME
export HOME="$original_home"
assert_failure
}
@test "setup.sh fails if PROMPT.md template missing" {
# Remove PROMPT.md template
rm -f templates/PROMPT.md
run bash "$SETUP_SCRIPT" test-project
assert_failure
}
# =============================================================================
# Test: Idempotency and Edge Cases
# =============================================================================
@test "setup.sh succeeds when run in an existing directory (idempotent)" {
# Create project directory first
mkdir -p existing-project
run bash "$SETUP_SCRIPT" existing-project
# The script uses mkdir -p which is idempotent, and git init works in existing dirs
# Templates will be copied over existing files, so this should succeed
[[ $status -eq 0 ]]
}
@test "setup.sh handles project name with spaces by creating directory" {
# Project names with spaces should work since the script uses "$PROJECT_NAME" with quotes
run bash "$SETUP_SCRIPT" "project with spaces"
# The script properly quotes variables, so spaces should be handled correctly
[[ $status -eq 0 ]]
}