da5640ef8e
Implements Issue #28 - modernize CLI commands for better Claude integration. Key changes: - Add JSON output format support with --output-format flag (default: json) - Add session continuity with --continue flag and .claude_session_id file - Add tool permissions via --allowed-tools flag - Add build_loop_context() for loop-aware context injection - Add detect_output_format() and parse_json_response() for JSON parsing - Maintain backward compatibility with text output fallback - Add version checking with check_claude_version() New CLI options: - --output-format json|text: Control Claude output format - --allowed-tools "Write,Read,Bash(git *)": Restrict tool permissions - --no-continue: Disable session continuity Test coverage: - 20 new JSON parsing tests (test_json_parsing.bats) - 23 new CLI modern tests (test_cli_modern.bats) - All 98 tests passing (100% pass rate)
443 lines
12 KiB
Bash
443 lines
12 KiB
Bash
#!/usr/bin/env bats
|
|
# Unit tests for JSON output parsing in response_analyzer.sh
|
|
# TDD: Write tests first, then implement
|
|
|
|
load '../helpers/test_helper'
|
|
load '../helpers/fixtures'
|
|
|
|
setup() {
|
|
# Create temporary test directory
|
|
TEST_DIR="$(mktemp -d)"
|
|
cd "$TEST_DIR"
|
|
|
|
# Initialize git repo for tests
|
|
git init > /dev/null 2>&1
|
|
git config user.email "test@example.com"
|
|
git config user.name "Test User"
|
|
|
|
# Set up environment
|
|
export PROMPT_FILE="PROMPT.md"
|
|
export LOG_DIR="logs"
|
|
export DOCS_DIR="docs/generated"
|
|
export STATUS_FILE="status.json"
|
|
export EXIT_SIGNALS_FILE=".exit_signals"
|
|
|
|
mkdir -p "$LOG_DIR" "$DOCS_DIR"
|
|
echo '{"test_only_loops": [], "done_signals": [], "completion_indicators": []}' > "$EXIT_SIGNALS_FILE"
|
|
|
|
# Source library components
|
|
source "${BATS_TEST_DIRNAME}/../../lib/response_analyzer.sh"
|
|
}
|
|
|
|
teardown() {
|
|
if [[ -n "$TEST_DIR" ]] && [[ -d "$TEST_DIR" ]]; then
|
|
cd /
|
|
rm -rf "$TEST_DIR"
|
|
fi
|
|
}
|
|
|
|
# =============================================================================
|
|
# JSON FORMAT DETECTION TESTS
|
|
# =============================================================================
|
|
|
|
@test "detect_output_format identifies valid JSON output" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
# Create JSON output
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE",
|
|
"exit_signal": true,
|
|
"work_type": "IMPLEMENTATION",
|
|
"files_modified": 5,
|
|
"error_count": 0,
|
|
"summary": "Implemented authentication module"
|
|
}
|
|
EOF
|
|
|
|
# Should detect as JSON
|
|
run detect_output_format "$output_file"
|
|
assert_equal "$output" "json"
|
|
}
|
|
|
|
@test "detect_output_format identifies text output" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
# Create text output
|
|
cat > "$output_file" << 'EOF'
|
|
Reading PROMPT.md...
|
|
Implementing feature X...
|
|
All tests passed.
|
|
Done.
|
|
EOF
|
|
|
|
# Should detect as text
|
|
run detect_output_format "$output_file"
|
|
assert_equal "$output" "text"
|
|
}
|
|
|
|
@test "detect_output_format handles mixed content (JSON with surrounding text)" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
# Create mixed output (Claude sometimes adds text around JSON)
|
|
cat > "$output_file" << 'EOF'
|
|
Starting execution...
|
|
|
|
{
|
|
"status": "IN_PROGRESS",
|
|
"exit_signal": false
|
|
}
|
|
|
|
Done processing.
|
|
EOF
|
|
|
|
# Should detect as text since it's not pure JSON
|
|
run detect_output_format "$output_file"
|
|
# Mixed content should be treated as text for safety
|
|
[[ "$output" == "text" || "$output" == "mixed" ]]
|
|
}
|
|
|
|
@test "detect_output_format handles empty file" {
|
|
local output_file="$LOG_DIR/empty.log"
|
|
touch "$output_file"
|
|
|
|
run detect_output_format "$output_file"
|
|
assert_equal "$output" "text"
|
|
}
|
|
|
|
# =============================================================================
|
|
# JSON PARSING TESTS
|
|
# =============================================================================
|
|
|
|
@test "parse_json_response extracts status field correctly" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE",
|
|
"exit_signal": true,
|
|
"work_type": "IMPLEMENTATION",
|
|
"files_modified": 5,
|
|
"error_count": 0,
|
|
"summary": "All tasks completed"
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
# Should create result file with parsed values
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
local status=$(jq -r '.status' "$result_file")
|
|
assert_equal "$status" "COMPLETE"
|
|
}
|
|
|
|
@test "parse_json_response extracts exit_signal correctly" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE",
|
|
"exit_signal": true,
|
|
"work_type": "IMPLEMENTATION"
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
local exit_signal=$(jq -r '.exit_signal' "$result_file")
|
|
assert_equal "$exit_signal" "true"
|
|
}
|
|
|
|
@test "parse_json_response maps IN_PROGRESS status to non-exit signal" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "IN_PROGRESS",
|
|
"exit_signal": false,
|
|
"work_type": "IMPLEMENTATION",
|
|
"files_modified": 3
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
local exit_signal=$(jq -r '.exit_signal' "$result_file")
|
|
assert_equal "$exit_signal" "false"
|
|
}
|
|
|
|
@test "parse_json_response identifies TEST_ONLY work type" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "IN_PROGRESS",
|
|
"exit_signal": false,
|
|
"work_type": "TEST_ONLY",
|
|
"files_modified": 0
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
local is_test_only=$(jq -r '.is_test_only' "$result_file")
|
|
assert_equal "$is_test_only" "true"
|
|
}
|
|
|
|
@test "parse_json_response extracts files_modified count" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "IN_PROGRESS",
|
|
"files_modified": 7,
|
|
"work_type": "IMPLEMENTATION"
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
local files=$(jq -r '.files_modified' "$result_file")
|
|
assert_equal "$files" "7"
|
|
}
|
|
|
|
@test "parse_json_response handles error_count field" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
# is_stuck threshold is >5 errors (matches response_analyzer.sh text parsing)
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "IN_PROGRESS",
|
|
"error_count": 6,
|
|
"work_type": "IMPLEMENTATION"
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
# High error count (>5) should indicate stuck state
|
|
local is_stuck=$(jq -r '.is_stuck' "$result_file")
|
|
assert_equal "$is_stuck" "true"
|
|
}
|
|
|
|
@test "parse_json_response extracts summary field" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE",
|
|
"summary": "Implemented user authentication with JWT tokens"
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
local summary=$(jq -r '.summary' "$result_file")
|
|
[[ "$summary" == *"authentication"* ]]
|
|
}
|
|
|
|
# =============================================================================
|
|
# JSON SCHEMA VALIDATION TESTS
|
|
# =============================================================================
|
|
|
|
@test "parse_json_response handles missing optional fields gracefully" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
# Minimal JSON with only required fields
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "IN_PROGRESS"
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
# Should not error, should use defaults
|
|
local status=$(jq -r '.status' "$result_file")
|
|
assert_equal "$status" "IN_PROGRESS"
|
|
}
|
|
|
|
@test "parse_json_response handles malformed JSON gracefully" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
# Invalid JSON
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE"
|
|
"missing_comma": true
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
# Should fail gracefully
|
|
[[ $status -ne 0 ]] || [[ "$output" == *"error"* ]] || [[ "$output" == *"fallback"* ]] || skip "parse_json_response not yet implemented"
|
|
}
|
|
|
|
@test "parse_json_response handles nested metadata object" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE",
|
|
"exit_signal": true,
|
|
"metadata": {
|
|
"loop_number": 5,
|
|
"timestamp": "2026-01-09T10:30:00Z",
|
|
"session_id": "abc123"
|
|
}
|
|
}
|
|
EOF
|
|
|
|
run parse_json_response "$output_file"
|
|
local result_file=".json_parse_result"
|
|
|
|
[[ -f "$result_file" ]] || skip "parse_json_response not yet implemented"
|
|
|
|
local loop_num=$(jq -r '.metadata.loop_number // .loop_number' "$result_file")
|
|
assert_equal "$loop_num" "5"
|
|
}
|
|
|
|
# =============================================================================
|
|
# INTEGRATION: analyze_response WITH JSON
|
|
# =============================================================================
|
|
|
|
@test "analyze_response detects JSON format and parses correctly" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE",
|
|
"exit_signal": true,
|
|
"work_type": "IMPLEMENTATION",
|
|
"files_modified": 5,
|
|
"error_count": 0,
|
|
"summary": "All authentication features completed"
|
|
}
|
|
EOF
|
|
|
|
analyze_response "$output_file" 1
|
|
local result=$?
|
|
|
|
assert_equal "$result" "0"
|
|
assert_file_exists ".response_analysis"
|
|
|
|
local exit_signal=$(jq -r '.analysis.exit_signal' .response_analysis)
|
|
assert_equal "$exit_signal" "true"
|
|
}
|
|
|
|
@test "analyze_response falls back to text parsing on JSON failure" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
# Invalid JSON but contains completion keywords
|
|
cat > "$output_file" << 'EOF'
|
|
{ invalid json here }
|
|
But the project is complete and all tasks are done.
|
|
EOF
|
|
|
|
analyze_response "$output_file" 1
|
|
local result=$?
|
|
|
|
assert_equal "$result" "0"
|
|
assert_file_exists ".response_analysis"
|
|
|
|
# Should still detect completion via text parsing
|
|
local has_completion=$(jq -r '.analysis.has_completion_signal' .response_analysis)
|
|
assert_equal "$has_completion" "true"
|
|
}
|
|
|
|
@test "analyze_response uses JSON confidence boost when available" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
{
|
|
"status": "COMPLETE",
|
|
"exit_signal": true,
|
|
"confidence": 95
|
|
}
|
|
EOF
|
|
|
|
analyze_response "$output_file" 1
|
|
|
|
# JSON with explicit exit_signal should have high confidence
|
|
local confidence=$(jq -r '.analysis.confidence_score' .response_analysis)
|
|
[[ "$confidence" -ge 50 ]]
|
|
}
|
|
|
|
# =============================================================================
|
|
# BACKWARD COMPATIBILITY TESTS
|
|
# =============================================================================
|
|
|
|
@test "analyze_response still handles traditional RALPH_STATUS format" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
Completed the implementation.
|
|
|
|
---RALPH_STATUS---
|
|
STATUS: COMPLETE
|
|
EXIT_SIGNAL: true
|
|
WORK_TYPE: IMPLEMENTATION
|
|
---END_RALPH_STATUS---
|
|
EOF
|
|
|
|
analyze_response "$output_file" 1
|
|
|
|
local exit_signal=$(jq -r '.analysis.exit_signal' .response_analysis)
|
|
assert_equal "$exit_signal" "true"
|
|
|
|
local confidence=$(jq -r '.analysis.confidence_score' .response_analysis)
|
|
[[ "$confidence" -ge 100 ]]
|
|
}
|
|
|
|
@test "analyze_response handles plain text completion signals" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
I have finished implementing all the requested features.
|
|
The project is complete and ready for review.
|
|
All tests are passing.
|
|
EOF
|
|
|
|
analyze_response "$output_file" 1
|
|
|
|
local has_completion=$(jq -r '.analysis.has_completion_signal' .response_analysis)
|
|
assert_equal "$has_completion" "true"
|
|
}
|
|
|
|
@test "analyze_response maintains text parsing for test-only detection" {
|
|
local output_file="$LOG_DIR/test_output.log"
|
|
|
|
cat > "$output_file" << 'EOF'
|
|
Running tests...
|
|
npm test
|
|
All tests passed successfully!
|
|
EOF
|
|
|
|
analyze_response "$output_file" 1
|
|
|
|
local is_test_only=$(jq -r '.analysis.is_test_only' .response_analysis)
|
|
assert_equal "$is_test_only" "true"
|
|
}
|