refactor(naming): remove @ prefix from on-disk filenames (#131 )

* refactor(naming): remove @ prefix from on-disk filenames

BREAKING CHANGE: Renames @fix_plan.md → fix_plan.md and @AGENT.md → AGENT.md

This change improves POSIX compliance and compatibility with command-line tools.
The @ prefix was originally used to avoid naming conflicts, but with the .ralph/
folder structure introduced in v0.10.0, this convention is no longer necessary.

Changes:
- Update all scripts to use new naming (fix_plan.md, AGENT.md)
- Update migration script to handle both old and new naming conventions
- Update templates to use new naming
- Update all documentation references
- Update all 420 tests to expect new naming (TDD approach)

Migration:
- Existing projects with @-prefixed files will be automatically renamed
  when running ralph-migrate
- Projects already using the new naming will continue to work unchanged

* docs(claude): update file naming conventions section

* fix(migrate): prevent orphaned @-prefixed files during migration

When both root/@fix_plan.md and .ralph/@fix_plan.md exist, the root file
now takes priority and the .ralph/@fix_plan.md is removed (backup exists).
This prevents orphaned legacy files after migration.

---------

Co-authored-by: Test User <test@example.com>

2026-01-26 15:40:27 -07:00

4.1 KiB

Raw Blame History

🎯 Ralph Test Implementation Status

Executive Summary

Completed: Phase 1-2 Test Infrastructure + Core Unit Tests + Integration Tests Test Count: 75 tests implemented (15 rate + 20 exit + 20 loop + 20 edge) Pass Rate: 100% (75/75 passing) Coverage: ~60% of codebase (excellent coverage of core paths) Status: ✅ SOLID FOUNDATION, WEEKS 1-2 + PARTIAL WEEK 5 COMPLETE

What Was Delivered

✅ Complete Test Infrastructure

BATS framework configured
Helper utilities created
Mock functions implemented
Fixture data library
CI/CD pipeline operational
npm test scripts configured

✅ 75 Tests (100% Pass)

Unit Tests (35 tests)
- Rate Limiting (15 tests): can_make_call(), increment_call_counter(), edge cases
- Exit Detection (20 tests): test saturation, done signals, completion indicators, fix_plan.md validation, error handling
Integration Tests (40 tests)
- Loop Execution (20 tests): response analyzer detection, circuit breaker states, full loop integration, exit signal detection
- Edge Cases (20 tests): empty/large/malformed output, corrupted JSON recovery, unicode/binary content, missing git, boundary conditions

✅ Documentation

IMPLEMENTATION_PLAN.md - 6-week detailed roadmap (updated 2025-12-31)
IMPLEMENTATION_STATUS.md - Current status tracking (updated 2025-12-31)
TEST_IMPLEMENTATION_SUMMARY.md - Achievement report
PHASE1_COMPLETION.md - Response analyzer + circuit breaker completion
PHASE2_COMPLETION.md - Integration tests completion
EXPERT_PANEL_REVIEW.md - Expert review and recommendations
Test helper documentation in code
CI/CD workflow documentation (.github/workflows/test.yml)

Test Results

$ npm test

✅ tests/unit/test_rate_limiting.bats: 15/15 passing
✅ tests/unit/test_exit_detection.bats: 20/20 passing
✅ tests/integration/test_loop_execution.bats: 20/20 passing
✅ tests/integration/test_edge_cases.bats: 20/20 passing

Total: 75/75 tests passing (100%)
Execution time: Variable (all tests pass)

Next Steps (Remaining from 6-Week Plan)

Immediate (Week 2 Completion)

CLI parsing tests (~10 tests) - test_cli_parsing.bats

Short-term (Weeks 3-4)

Installation tests (~10 tests)
Project setup tests (~8 tests)
PRD import tests (~10 tests)
tmux integration tests (~12 tests)
Monitor dashboard tests (~8 tests)
Status update tests (~6 tests)

Medium-term (Week 5 Completion + Week 6)

Week 5 Features: log rotation, dry-run mode, config file support (~15 tests)
Week 6 Features: metrics, notifications, backup/rollback (~12 tests)
E2E tests (~10 tests) - full loop scenarios

Total Remaining: ~90 tests to reach 140+ test goal and 90%+ coverage

Files Created/Updated

tests/
├── unit/
│   ├── test_rate_limiting.bats        ✅ 15 tests
│   └── test_exit_detection.bats       ✅ 20 tests
├── integration/
│   ├── test_loop_execution.bats       ✅ 20 tests
│   └── test_edge_cases.bats           ✅ 20 tests
├── helpers/
│   ├── test_helper.bash               ✅ Core utilities
│   ├── mocks.bash                     ✅ Mock system
│   └── fixtures.bash                  ✅ Test data
lib/
├── response_analyzer.sh               ✅ Response analysis
├── circuit_breaker.sh                 ✅ Circuit breaker
└── date_utils.sh                      ✅ Cross-platform dates
.github/workflows/test.yml             ✅ CI/CD
package.json                           ✅ Test scripts
IMPLEMENTATION_PLAN.md                 ✅ Roadmap (updated 2025-12-31)
IMPLEMENTATION_STATUS.md               ✅ Status (updated 2025-12-31)
TEST_IMPLEMENTATION_SUMMARY.md         ✅ Report
PHASE1_COMPLETION.md                   ✅ Phase 1 milestone
PHASE2_COMPLETION.md                   ✅ Phase 2 milestone

How to Use

# Run all tests
npm test

# Run specific file
npx bats tests/unit/test_rate_limiting.bats

# Continue implementation
# Follow IMPLEMENTATION_PLAN.md weeks 2-6

Generated: 2025-09-30 Last Updated: 2025-12-31 See Also: IMPLEMENTATION_STATUS.md for detailed current status

4.1 KiB Raw Blame History